RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 05:57:45 +00:00
Code Issues Activity Actions

Kernel: Fix up various PCI-related function signatures

Browse source 
- Make things const when they don't need to be non-const.
- Don't return AK::String when it's always a string literal anyway.
- Remove excessive get_ prefixes per coding style.
This commit is contained in:
Andreas Kling 2020-04-08 17:09:49 +02:00
parent 15cffc4089
commit 44e889785a
4 changed files with 29 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Kernel/PCI/MMIOAccess.h
View file

@ -42,8 +42,8 @@ public:
static void initialize(PhysicalAddress mcfg);
virtual void enumerate_all(Function<void(Address, ID)>&) override final;
virtual String get_access_type() override final { return "MMIO-Access"; };
virtual u32 get_segments_count();
virtual const char* access_type() const override { return "MMIO-Access"; };
virtual u32 segment_count() const override;
virtual void write8_field(Address address, u32, u8) override final;
virtual void write16_field(Address address, u32, u16) override final;
@ -58,8 +58,8 @@ private:
virtual u32 read32_field(Address address, u32) override final;
void map_device(Address address);
virtual u8 get_segment_start_bus(u32);
virtual u8 get_segment_end_bus(u32);
virtual u8 segment_start_bus(u32) const override;
virtual u8 segment_end_bus(u32) const override;
PhysicalAddress m_mcfg;
HashMap<u16, MMIOSegment*>& m_segments;