1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 05:57:44 +00:00

LibWeb: Fix position: fixed canvases/images disappearing when scrolling

This fixes the Serenity logo vanishing after scrolling on the 4th
birthday post.

The previous check did not account for any translation in the painter.
This now uses the painter's clip rect and translation to work out
if a rect is visible. It also makes use of `absolute_paint_rect()`
rather than `absolute_rect()` which can account for things like
box-shadows.
This commit is contained in:
MacDue 2022-10-10 21:28:57 +01:00 committed by Andreas Kling
parent f5e68fcc20
commit 4507920187
4 changed files with 13 additions and 4 deletions

View file

@ -37,6 +37,13 @@ void PaintableBox::invalidate_stacking_context()
m_stacking_context = nullptr;
}
bool PaintableBox::is_out_of_view(PaintContext& context) const
{
return !enclosing_int_rect(absolute_paint_rect())
.translated(context.painter().translation())
.intersects(context.painter().clip_rect());
}
PaintableWithLines::PaintableWithLines(Layout::BlockContainer const& layout_box)
: PaintableBox(layout_box)
{