From 4547a301c4c4ba761a73f58dccb76075f2fcba12 Mon Sep 17 00:00:00 2001 From: Robin Burchell Date: Fri, 19 Jul 2019 16:02:37 +0200 Subject: [PATCH] Thread: Fix a regression introduced in 80a6df90220981e64e0ca192908163d3a263ffc6 Accidentally forgot to check the state parameter, which made this rather useless. Bug found, and cause identified by Andreas --- Kernel/Thread.h | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/Kernel/Thread.h b/Kernel/Thread.h index e31e39f3a9..737c1f0daa 100644 --- a/Kernel/Thread.h +++ b/Kernel/Thread.h @@ -312,9 +312,14 @@ template inline IterationDecision Thread::for_each_in_state(State state, Callback callback) { ASSERT_INTERRUPTS_DISABLED(); + auto new_callback = [=](Thread& thread) -> IterationDecision { + if (thread.state() == state) + return callback(thread); + return IterationDecision::Continue; + }; if (is_runnable_state(state)) - return for_each_runnable(callback); - return for_each_nonrunnable(callback); + return for_each_runnable(new_callback); + return for_each_nonrunnable(new_callback); } template