RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-23 20:57:41 +00:00
Code Issues Activity Actions

Kernel: Harden sys$readv / sys$writev Vector usage against OOM.

Browse source
This commit is contained in:
Brian Gianforcaro 2021-04-29 01:20:24 -07:00 • committed by Andreas Kling
parent cd29eb7867
commit 454d2fd42a
2 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Kernel/Syscalls/read.cpp
View file

@ -24,7 +24,8 @@ KResultOr<ssize_t> Process::sys$readv(int fd, Userspace<const struct iovec*> iov
u64 total_length = 0; u64 total_length = 0;
Vector<iovec, 32> vecs; Vector<iovec, 32> vecs;
vecs.resize(iov_count); if (!vecs.try_resize(iov_count))
return ENOMEM;
if (!copy_n_from_user(vecs.data(), iov, iov_count)) if (!copy_n_from_user(vecs.data(), iov, iov_count))
return EFAULT; return EFAULT;
for (auto& vec : vecs) { for (auto& vec : vecs) {

3
Kernel/Syscalls/write.cpp
View file

@ -23,7 +23,8 @@ KResultOr<ssize_t> Process::sys$writev(int fd, Userspace<const struct iovec*> io
u64 total_length = 0; u64 total_length = 0;
Vector<iovec, 32> vecs; Vector<iovec, 32> vecs;
vecs.resize(iov_count); if (!vecs.try_resize(iov_count))
return ENOMEM;
if (!copy_n_from_user(vecs.data(), iov, iov_count)) if (!copy_n_from_user(vecs.data(), iov, iov_count))
return EFAULT; return EFAULT;
for (auto& vec : vecs) { for (auto& vec : vecs) {