RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 14:28:12 +00:00
Code Issues Activity Actions

LibWeb: Create LayoutNodes for each SVG element

Browse source 
This brings the SVG API closer to the rest of LibWeb
This commit is contained in:
Matthew Olsson 2020-10-05 16:14:36 -07:00 • committed by Andreas Kling
parent f2055bb509
commit 455ce0b9c3
16 changed files with 402 additions and 122 deletions
Download patch file Download diff file Expand all files Collapse all files

51
Libraries/LibWeb/SVG/SVGSVGElement.cpp
View file

@ -28,15 +28,13 @@
#include <LibWeb/CSS/StyleResolver.h>
#include <LibWeb/DOM/Document.h>
#include <LibWeb/DOM/Event.h>
#include <LibWeb/Layout/LayoutSVG.h>
#include <LibWeb/Layout/LayoutSVGSVG.h>
#include <LibWeb/SVG/SVGPathElement.h>
#include <LibWeb/SVG/SVGSVGElement.h>
#include <ctype.h>
namespace Web::SVG {
static constexpr auto max_svg_area = 16384 * 16384;
SVGSVGElement::SVGSVGElement(DOM::Document& document, const FlyString& tag_name)
: SVGGraphicsElement(document, tag_name)
{
@ -47,43 +45,7 @@ RefPtr<LayoutNode> SVGSVGElement::create_layout_node(const CSS::StyleProperties*
auto style = document().style_resolver().resolve_style(*this, parent_style);
if (style->display() == CSS::Display::None)
return nullptr;
return adopt(*new LayoutSVG(document(), *this, move(style)));
}
static Gfx::IntSize bitmap_size_for_canvas(const SVGSVGElement& canvas)
{
auto width = canvas.width();
auto height = canvas.height();
Checked<size_t> area = width;
area *= height;
if (area.has_overflow()) {
dbg() << "Refusing to create " << width << "x" << height << " svg (overflow)";
return {};
}
if (area.value() > max_svg_area) {
dbg() << "Refusing to create " << width << "x" << height << " svg (exceeds maximum size)";
return {};
}
return Gfx::IntSize(width, height);
}
bool SVGSVGElement::create_bitmap_as_top_level_svg_element()
{
auto size = bitmap_size_for_canvas(*this);
if (size.is_empty()) {
m_bitmap = nullptr;
return false;
}
if (!m_bitmap || m_bitmap->size() != size)
m_bitmap = Gfx::Bitmap::create(Gfx::BitmapFormat::RGBA32, size);
Gfx::Painter painter(*m_bitmap);
paint(painter, make_painting_context_from(default_painting_context));
return m_bitmap;
return adopt(*new LayoutSVGSVG(document(), *this, move(style)));
}
unsigned SVGSVGElement::width() const
@ -96,13 +58,4 @@ unsigned SVGSVGElement::height() const
return attribute(HTML::AttributeNames::height).to_uint().value_or(150);
}
void SVGSVGElement::paint(Gfx::Painter& painter, const SVGPaintingContext& context)
{
for_each_child([&](Node& child) {
if (is<SVGGraphicsElement>(child)) {
downcast<SVGGraphicsElement>(child).paint(painter, make_painting_context_from(context));
}
});
}
}