mirror of
https://github.com/RGBCube/serenity
synced 2025-07-27 07:27:45 +00:00
Everywhere: Convert ByteBuffer factory methods from Optional -> ErrorOr
Apologies for the enormous commit, but I don't see a way to split this up nicely. In the vast majority of cases it's a simple change. A few extra places can use TRY instead of manual error checking though. :^)
This commit is contained in:
parent
140f1d9e55
commit
45cf40653a
79 changed files with 202 additions and 274 deletions
|
@ -387,11 +387,7 @@ ErrorOr<void> BrowserWindow::load_search_engines(GUI::Menu& settings_menu)
|
|||
|
||||
auto search_engines_file = TRY(Core::Stream::File::open(Browser::search_engines_file_path(), Core::Stream::OpenMode::Read));
|
||||
auto file_size = TRY(search_engines_file->size());
|
||||
auto maybe_buffer = ByteBuffer::create_uninitialized(file_size);
|
||||
if (!maybe_buffer.has_value())
|
||||
return Error::from_string_literal("Unable to allocate buffer for reading search-engines file.");
|
||||
|
||||
auto buffer = maybe_buffer.release_value();
|
||||
auto buffer = TRY(ByteBuffer::create_uninitialized(file_size));
|
||||
if (search_engines_file->read_or_error(buffer)) {
|
||||
StringView buffer_contents { buffer.bytes() };
|
||||
if (auto json = TRY(JsonValue::from_string(buffer_contents)); json.is_array()) {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue