mirror of
https://github.com/RGBCube/serenity
synced 2025-07-27 01:47:35 +00:00
Everywhere: Convert ByteBuffer factory methods from Optional -> ErrorOr
Apologies for the enormous commit, but I don't see a way to split this up nicely. In the vast majority of cases it's a simple change. A few extra places can use TRY instead of manual error checking though. :^)
This commit is contained in:
parent
140f1d9e55
commit
45cf40653a
79 changed files with 202 additions and 274 deletions
|
@ -99,13 +99,9 @@ public:
|
|||
m_current_byte.clear();
|
||||
}
|
||||
} else {
|
||||
// FIXME: This returns Optional so TRY is not useable
|
||||
auto temp_buffer = ByteBuffer::create_uninitialized(1);
|
||||
if (!temp_buffer.has_value())
|
||||
return Error::from_string_literal("Couldn't allocate temporary byte buffer"sv);
|
||||
|
||||
TRY(m_stream.read(temp_buffer->bytes()));
|
||||
m_current_byte = (*temp_buffer)[0];
|
||||
auto temp_buffer = TRY(ByteBuffer::create_uninitialized(1));
|
||||
TRY(m_stream.read(temp_buffer.bytes()));
|
||||
m_current_byte = temp_buffer[0];
|
||||
m_bit_offset = 0;
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue