mirror of
https://github.com/RGBCube/serenity
synced 2025-07-27 04:17:35 +00:00
Everywhere: Convert ByteBuffer factory methods from Optional -> ErrorOr
Apologies for the enormous commit, but I don't see a way to split this up nicely. In the vast majority of cases it's a simple change. A few extra places can use TRY instead of manual error checking though. :^)
This commit is contained in:
parent
140f1d9e55
commit
45cf40653a
79 changed files with 202 additions and 274 deletions
|
@ -167,14 +167,12 @@ ErrorOr<void> ConnectionBase::drain_messages_from_peer()
|
|||
// Sometimes we might receive a partial message. That's okay, just stash away
|
||||
// the unprocessed bytes and we'll prepend them to the next incoming message
|
||||
// in the next run of this function.
|
||||
auto maybe_remaining_bytes = ByteBuffer::copy(bytes.span().slice(index));
|
||||
if (!maybe_remaining_bytes.has_value())
|
||||
return Error::from_string_literal("drain_messages_from_peer: Failed to allocate buffer"sv);
|
||||
auto remaining_bytes = TRY(ByteBuffer::copy(bytes.span().slice(index)));
|
||||
if (!m_unprocessed_bytes.is_empty()) {
|
||||
shutdown();
|
||||
return Error::from_string_literal("drain_messages_from_peer: Already have unprocessed bytes"sv);
|
||||
}
|
||||
m_unprocessed_bytes = maybe_remaining_bytes.release_value();
|
||||
m_unprocessed_bytes = move(remaining_bytes);
|
||||
}
|
||||
|
||||
if (!m_unprocessed_messages.is_empty()) {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue