mirror of
https://github.com/RGBCube/serenity
synced 2025-07-28 15:07:44 +00:00
Everywhere: Convert ByteBuffer factory methods from Optional -> ErrorOr
Apologies for the enormous commit, but I don't see a way to split this up nicely. In the vast majority of cases it's a simple change. A few extra places can use TRY instead of manual error checking though. :^)
This commit is contained in:
parent
140f1d9e55
commit
45cf40653a
79 changed files with 202 additions and 274 deletions
|
@ -45,8 +45,8 @@ Optional<ByteBuffer> Filter::decode_ascii_hex(ReadonlyBytes bytes)
|
|||
// FIXME: Integrate this padding into AK/Hex?
|
||||
|
||||
auto output_result = ByteBuffer::create_zeroed(bytes.size() / 2 + 1);
|
||||
if (!output_result.has_value())
|
||||
return output_result;
|
||||
if (output_result.is_error())
|
||||
return {};
|
||||
|
||||
auto output = output_result.release_value();
|
||||
|
||||
|
@ -120,7 +120,10 @@ Optional<ByteBuffer> Filter::decode_ascii85(ReadonlyBytes bytes)
|
|||
buff.append(reinterpret_cast<u8*>(&number)[3 - i]);
|
||||
}
|
||||
|
||||
return ByteBuffer::copy(buff.span());
|
||||
auto result = ByteBuffer::copy(buff.span());
|
||||
if (result.is_error())
|
||||
return {};
|
||||
return result.release_value();
|
||||
};
|
||||
|
||||
Optional<ByteBuffer> Filter::decode_lzw(ReadonlyBytes)
|
||||
|
|
|
@ -270,7 +270,7 @@ bool Parser::initialize_hint_tables()
|
|||
auto total_size = primary_size + overflow_size;
|
||||
|
||||
auto buffer_result = ByteBuffer::create_uninitialized(total_size);
|
||||
if (!buffer_result.has_value())
|
||||
if (buffer_result.is_error())
|
||||
return false;
|
||||
possible_merged_stream_buffer = buffer_result.release_value();
|
||||
auto ok = !possible_merged_stream_buffer.try_append(primary_hint_stream->bytes()).is_error();
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue