RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 11:38:11 +00:00
Code Issues Activity Actions

LibJS: Add getter/setter support

Browse source 
This patch adds a GetterSetterPair object. Values can now store pointers
to objects of this type. These objects are created when using
Object.defineProperty and providing an accessor descriptor.
This commit is contained in:
Matthew Olsson 2020-05-21 11:14:23 -07:00 • committed by Andreas Kling
parent a4d04cc748
commit 45dfa094e9
7 changed files with 259 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Libraries/LibJS/Runtime/Value.cpp
View file

@ -29,6 +29,7 @@
#include <AK/StringBuilder.h>
#include <LibJS/Heap/Heap.h>
#include <LibJS/Interpreter.h>
#include <LibJS/Runtime/Accessor.h>
#include <LibJS/Runtime/Array.h>
#include <LibJS/Runtime/BooleanObject.h>
#include <LibJS/Runtime/Error.h>
@ -63,6 +64,12 @@ Function& Value::as_function()
return static_cast<Function&>(as_object());
}
Accessor& Value::as_accessor()
{
ASSERT(is_accessor());
return static_cast<Accessor&>(*m_value.as_accessor);
}
String Value::to_string_without_side_effects() const
{
if (is_boolean())
@ -92,6 +99,9 @@ String Value::to_string_without_side_effects() const
if (is_symbol())
return as_symbol().to_string();
if (is_accessor())
return "<accessor>";
ASSERT(is_object());
return String::format("[object %s]", as_object().class_name());
}
@ -205,6 +215,7 @@ Value Value::to_number(Interpreter& interpreter) const
{
switch (m_type) {
case Type::Empty:
case Type::Accessor:
ASSERT_NOT_REACHED();
return {};
case Type::Undefined: