From 460303b2fee40ceafbf2372233a2f77a4d089182 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Thu, 2 Mar 2023 20:49:29 +0100 Subject: [PATCH] LibGfx: Draw checkbox check in the center of the checkbox rect This looks better at larger checkbox sizes than just drawing it in the top left corner. Ideally we'd have a scalable checkmark, of course. --- Userland/Libraries/LibGfx/ClassicStylePainter.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Userland/Libraries/LibGfx/ClassicStylePainter.cpp b/Userland/Libraries/LibGfx/ClassicStylePainter.cpp index e09c5b99fb..007febdbb2 100644 --- a/Userland/Libraries/LibGfx/ClassicStylePainter.cpp +++ b/Userland/Libraries/LibGfx/ClassicStylePainter.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018-2020, Andreas Kling + * Copyright (c) 2018-2023, Andreas Kling * Copyright (c) 2020, Sarah Taube * Copyright (c) 2021, Filiph Sandström * Copyright (c) 2022, Cameron Youell @@ -563,7 +563,8 @@ void ClassicStylePainter::paint_check_box(Painter& painter, IntRect const& rect, } if (is_checked) { - painter.draw_bitmap(rect.shrunken(4, 4).location(), s_checked_bitmap, is_enabled ? palette.base_text() : palette.threed_shadow1()); + auto check_rect = Gfx::IntRect({}, s_checked_bitmap.size()).centered_within(rect); + painter.draw_bitmap(check_rect.location(), s_checked_bitmap, is_enabled ? palette.base_text() : palette.threed_shadow1()); } }