RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-06-01 11:18:13 +00:00
Code Issues Activity Actions

AK: Let's just log unimplemented printf() format strings

Browse source 
It's too dang frustrating that we actually crash whenever we hit some
unimplemented printf specifier. Let's just log the whole format string
and carry on as best we can.
This commit is contained in:
Andreas Kling 2019-11-04 20:44:04 +01:00
parent 715d7a8532
commit 4623811ec3
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
AK/PrintfImplementation.h
View file

@ -250,6 +250,9 @@ template<typename PutChFunc>
if (*p == '%' && *(p + 1)) {
one_more:
++p;
// FIXME: This is just a hack workaround to prevent choking on '.' specifiers
if (*p == '.')
goto one_more;
if (*p == '-') {
left_pad = true;
if (*(p + 1))
@ -356,8 +359,7 @@ template<typename PutChFunc>
ret += print_hex(putch, bufptr, va_arg(ap, u32), *p == 'P', true, false, true, 8);
break;
default:
dbg() << "printf_internal: Unimplemented format specifier " << *p;
ASSERT_NOT_REACHED();
dbg() << "printf_internal: Unimplemented format specifier " << *p << " (fmt: " << fmt << ")";
}
} else {
putch(bufptr, *p);