RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 04:37:44 +00:00
Code Issues Activity Actions

Applications: Fix visibility of Object-derivative constructors

Browse source 
Derivatives of Core::Object should be constructed through
ClassName::construct(), to avoid handling ref-counted objects with
refcount zero. Fixing the visibility means that misuses like this are
more difficult.
This commit is contained in:
Ben Wiederhake 2021-10-31 23:38:04 +01:00 • committed by Andreas Kling
parent 6b75a4dfc3
commit 465af4c4d4
13 changed files with 53 additions and 43 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Applets/Network/main.cpp
View file

@ -20,7 +20,7 @@
class NetworkWidget final : public GUI::ImageWidget {
C_OBJECT(NetworkWidget);
public:
private:
NetworkWidget(bool notifications)
{
m_notifications = notifications;
@ -28,7 +28,6 @@ public:
start_timer(5000);
}
private:
virtual void timer_event(Core::TimerEvent&) override
{
update_widget();