RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 05:47:34 +00:00
Code Issues Activity Actions

Applications: Fix visibility of Object-derivative constructors

Browse source 
Derivatives of Core::Object should be constructed through
ClassName::construct(), to avoid handling ref-counted objects with
refcount zero. Fixing the visibility means that misuses like this are
more difficult.
This commit is contained in:
Ben Wiederhake 2021-10-31 23:38:04 +01:00 • committed by Andreas Kling
parent 6b75a4dfc3
commit 465af4c4d4
13 changed files with 53 additions and 43 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Applications/KeyboardMapper/KeyboardMapperWidget.h
View file

@ -10,11 +10,10 @@
#include <LibGUI/Button.h>
#include <LibKeyboard/CharacterMapData.h>
class KeyboardMapperWidget : public GUI::Widget {
class KeyboardMapperWidget final : public GUI::Widget {
C_OBJECT(KeyboardMapperWidget)
public:
KeyboardMapperWidget();
virtual ~KeyboardMapperWidget() override;
void create_frame();
@ -31,6 +30,8 @@ protected:
void update_window_title();
private:
KeyboardMapperWidget();
Vector<KeyButton*> m_keys;
RefPtr<GUI::Widget> m_map_group;