RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 13:37:45 +00:00
Code Issues Activity Actions

Applications: Fix visibility of Object-derivative constructors

Browse source 
Derivatives of Core::Object should be constructed through
ClassName::construct(), to avoid handling ref-counted objects with
refcount zero. Fixing the visibility means that misuses like this are
more difficult.
This commit is contained in:
Ben Wiederhake 2021-10-31 23:38:04 +01:00 • committed by Andreas Kling
parent 6b75a4dfc3
commit 465af4c4d4
13 changed files with 53 additions and 43 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Applications/PDFViewer/NumericInput.h
View file

@ -12,7 +12,6 @@
class NumericInput final : public GUI::TextBox {
C_OBJECT(NumericInput)
public:
NumericInput();
virtual ~NumericInput() override = default;
Function<void(i32)> on_number_changed;
@ -22,6 +21,7 @@ public:
void set_current_number(i32 number, bool call_change_handler = true);
private:
NumericInput();
void on_focus_lost();
bool m_needs_text_reset { false };