RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 23:07:35 +00:00
Code Issues Activity Actions

Applications: Fix visibility of Object-derivative constructors

Browse source 
Derivatives of Core::Object should be constructed through
ClassName::construct(), to avoid handling ref-counted objects with
refcount zero. Fixing the visibility means that misuses like this are
more difficult.
This commit is contained in:
Ben Wiederhake 2021-10-31 23:38:04 +01:00 • committed by Andreas Kling
parent 6b75a4dfc3
commit 465af4c4d4
13 changed files with 53 additions and 43 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Applications/SoundPlayer/Common.h
View file

@ -21,7 +21,7 @@ public:
bool mouse_is_down() const { return m_mouse_is_down; }
protected:
private:
AutoSlider(Orientation orientation)
: GUI::Slider(orientation)
{
@ -42,6 +42,5 @@ protected:
GUI::Slider::mouseup_event(event);
}
private:
bool m_mouse_is_down { false };
};

2
Userland/Applications/SoundPlayer/PlaylistWidget.cpp
View file

@ -92,6 +92,8 @@ String PlaylistModel::column_name(int column) const
VERIFY_NOT_REACHED();
}
PlaylistTableView::PlaylistTableView() = default;
void PlaylistTableView::doubleclick_event(GUI::MouseEvent& event)
{
AbstractView::doubleclick_event(event);

7
Userland/Applications/SoundPlayer/PlaylistWidget.h
View file

@ -40,19 +40,22 @@ public:
void doubleclick_event(GUI::MouseEvent& event) override;
Function<void(const Gfx::Point<int>&)> on_doubleclick;
private:
PlaylistTableView();
};
class PlaylistWidget : public GUI::Widget {
C_OBJECT(PlaylistWidget)
public:
PlaylistWidget();
void set_data_model(RefPtr<PlaylistModel> model)
{
m_table_view->set_model(model);
m_table_view->update();
}
protected:
private:
PlaylistWidget();
RefPtr<PlaylistTableView> m_table_view;
};

4
Userland/Applications/SoundPlayer/SoundPlayerWidgetAdvancedView.h
View file

@ -21,8 +21,6 @@ class SoundPlayerWidgetAdvancedView final : public GUI::Widget
C_OBJECT(SoundPlayerWidgetAdvancedView)
public:
explicit SoundPlayerWidgetAdvancedView(GUI::Window&, Audio::ClientConnection&);
void set_nonlinear_volume_slider(bool nonlinear);
void set_playlist_visible(bool visible);
@ -51,6 +49,8 @@ protected:
void keydown_event(GUI::KeyEvent&) override;
private:
SoundPlayerWidgetAdvancedView(GUI::Window&, Audio::ClientConnection&);
void sync_previous_next_buttons();
void drop_event(GUI::DropEvent& event) override;

1
Userland/Applications/SoundPlayer/VisualizationWidget.h
View file

@ -17,5 +17,6 @@ public:
virtual void set_samplerate(int) { }
protected:
VisualizationWidget() = default;
virtual ~VisualizationWidget() = default;
};