RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 06:07:34 +00:00
Code Issues Activity Actions

Applications: Fix visibility of Object-derivative constructors

Browse source 
Derivatives of Core::Object should be constructed through
ClassName::construct(), to avoid handling ref-counted objects with
refcount zero. Fixing the visibility means that misuses like this are
more difficult.
This commit is contained in:
Ben Wiederhake 2021-10-31 23:38:04 +01:00 • committed by Andreas Kling
parent 6b75a4dfc3
commit 465af4c4d4
13 changed files with 53 additions and 43 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Applications/SoundPlayer/Common.h
View file

@ -21,7 +21,7 @@ public:
bool mouse_is_down() const { return m_mouse_is_down; }
protected:
private:
AutoSlider(Orientation orientation)
: GUI::Slider(orientation)
{
@ -42,6 +42,5 @@ protected:
GUI::Slider::mouseup_event(event);
}
private:
bool m_mouse_is_down { false };
};