RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 00:57:45 +00:00
Code Issues Activity Actions

LibJS: Use forwarding references for call's variadic template arguments

Browse source
This commit is contained in:
Timothy Flynn 2022-01-25 15:04:06 -05:00 • committed by Linus Groh
parent 5c4b1e3d23
commit 4661a0f228
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibJS/Runtime/AbstractOperations.h
View file

@ -65,11 +65,11 @@ ALWAYS_INLINE ThrowCompletionOr<Value> call(GlobalObject& global_object, Value f
} }
template<typename... Args> template<typename... Args>
ALWAYS_INLINE ThrowCompletionOr<Value> call(GlobalObject& global_object, Value function, Value this_value, Args... args) ALWAYS_INLINE ThrowCompletionOr<Value> call(GlobalObject& global_object, Value function, Value this_value, Args&&... args)
{ {
if constexpr (sizeof...(Args) > 0) { if constexpr (sizeof...(Args) > 0) {
MarkedValueList arguments_list { global_object.heap() }; MarkedValueList arguments_list { global_object.heap() };
(..., arguments_list.append(move(args))); (..., arguments_list.append(forward<Args>(args)));
return call_impl(global_object, function, this_value, move(arguments_list)); return call_impl(global_object, function, this_value, move(arguments_list));
} }
@ -87,11 +87,11 @@ ALWAYS_INLINE ThrowCompletionOr<Value> call(GlobalObject& global_object, Functio
} }
template<typename... Args> template<typename... Args>
ALWAYS_INLINE ThrowCompletionOr<Value> call(GlobalObject& global_object, FunctionObject& function, Value this_value, Args... args) ALWAYS_INLINE ThrowCompletionOr<Value> call(GlobalObject& global_object, FunctionObject& function, Value this_value, Args&&... args)
{ {
if constexpr (sizeof...(Args) > 0) { if constexpr (sizeof...(Args) > 0) {
MarkedValueList arguments_list { global_object.heap() }; MarkedValueList arguments_list { global_object.heap() };
(..., arguments_list.append(move(args))); (..., arguments_list.append(forward<Args>(args)));
return call_impl(global_object, function, this_value, move(arguments_list)); return call_impl(global_object, function, this_value, move(arguments_list));
} }