RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 01:27:34 +00:00
Code Issues Activity Actions

LookupServer: Use case-insensitive comparison for domain names

Browse source 
Some ISPs may MITM DNS requests coming from clients, changing the case
of domain name in response. LookupServer will refuse responses from
any DNS server in that case. This commit changes the behaviour to
perform a case-insensitive equality check.
This commit is contained in:
Timur Sultanov 2022-03-27 17:41:12 +03:00 • committed by Andreas Kling
parent f38076e596
commit 46710d9efa
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Services/LookupServer/LookupServer.cpp
View file

@ -269,14 +269,14 @@ ErrorOr<Vector<DNSAnswer>> LookupServer::lookup(const DNSName& name, const Strin
return Vector<DNSAnswer> {};
}
// Verify the questions in our request and in their response match exactly, including case.
// Verify the questions in our request and in their response match, ignoring case.
for (size_t i = 0; i < request.question_count(); ++i) {
auto& request_question = request.questions()[i];
auto& response_question = response.questions()[i];
bool exact_match = request_question.class_code() == response_question.class_code()
bool match = request_question.class_code() == response_question.class_code()
&& request_question.record_type() == response_question.record_type()
&& request_question.name().as_string() == response_question.name().as_string();
if (!exact_match) {
&& request_question.name().as_string().equals_ignoring_case(response_question.name().as_string());
if (!match) {
dbgln("Request and response questions do not match");
dbgln(" Request: name=_{}_, type={}, class={}", request_question.name().as_string(), response_question.record_type(), response_question.class_code());
dbgln(" Response: name=_{}_, type={}, class={}", response_question.name().as_string(), response_question.record_type(), response_question.class_code());