RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 04:37:44 +00:00
Code Issues Activity Actions

LibJS: Make BlockDeclarationInstantiation take a VM&

Browse source 
There's no need for this to require an AST Interpreter.
This commit is contained in:
Andreas Kling 2023-06-16 16:12:11 +02:00
parent 9e95c9892c
commit 4684d3fe54
2 changed files with 4 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibJS/AST.cpp
View file

@ -246,7 +246,7 @@ Completion BlockStatement::execute(Interpreter& interpreter) const
old_environment = vm.running_execution_context().lexical_environment;
auto block_environment = new_declarative_environment(*old_environment);
block_declaration_instantiation(interpreter, block_environment);
block_declaration_instantiation(vm, block_environment);
vm.running_execution_context().lexical_environment = block_environment;
// 5. Let blockValue be the result of evaluating StatementList.
@ -4309,7 +4309,7 @@ Completion SwitchStatement::execute_impl(Interpreter& interpreter) const
auto block_environment = new_declarative_environment(*old_environment);
// 5. Perform BlockDeclarationInstantiation(CaseBlock, blockEnv).
block_declaration_instantiation(interpreter, block_environment);
block_declaration_instantiation(vm, block_environment);
// 6. Set the running execution context's LexicalEnvironment to blockEnv.
vm.running_execution_context().lexical_environment = block_environment;
@ -4729,10 +4729,9 @@ bool ImportStatement::has_bound_name(DeprecatedFlyString const& name) const
}
// 14.2.3 BlockDeclarationInstantiation ( code, env ), https://tc39.es/ecma262/#sec-blockdeclarationinstantiation
void ScopeNode::block_declaration_instantiation(Interpreter& interpreter, Environment* environment) const
void ScopeNode::block_declaration_instantiation(VM& vm, Environment* environment) const
{
// See also B.3.2.6 Changes to BlockDeclarationInstantiation, https://tc39.es/ecma262/#sec-web-compat-blockdeclarationinstantiation
auto& vm = interpreter.vm();
auto& realm = *vm.current_realm();
VERIFY(environment);