RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 11:48:10 +00:00
Code Issues Activity Actions

Applications: Stop calling set_tooltip_deprecated when we do have String

Browse source
This commit is contained in:
Karol Kosek 2023-09-10 21:02:52 +02:00 • committed by Andreas Kling
parent 9c923f20f4
commit 46a97844c7
3 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Applications/DisplaySettings/MonitorSettingsWidget.cpp
View file

@ -216,7 +216,7 @@ ErrorOr<void> MonitorSettingsWidget::selected_screen_index_or_resolution_changed
if (screen_dpi.has_value()) { if (screen_dpi.has_value()) {
auto dpi_label_value = TRY(String::formatted("{} dpi", screen_dpi.value())); auto dpi_label_value = TRY(String::formatted("{} dpi", screen_dpi.value()));
m_dpi_label->set_tooltip_deprecated(screen_dpi_tooltip.to_deprecated_string()); m_dpi_label->set_tooltip(screen_dpi_tooltip);
m_dpi_label->set_text(move(dpi_label_value)); m_dpi_label->set_text(move(dpi_label_value));
m_dpi_label->set_visible(true); m_dpi_label->set_visible(true);
} else { } else {

2
Userland/Applications/Piano/ProcessorParameterWidget/Slider.cpp
View file

@ -26,7 +26,7 @@ ProcessorParameterSlider::ProcessorParameterSlider(Orientation orientation, DSP:
set_value(value_log); set_value(value_log);
set_step((min_log - max_log) / slider_steps); set_step((min_log - max_log) / slider_steps);
} }
set_tooltip_deprecated(m_parameter.name().to_deprecated_string()); set_tooltip(m_parameter.name());
if (m_value_label != nullptr) if (m_value_label != nullptr)
m_value_label->set_text(String::formatted("{:.2f}", static_cast<double>(m_parameter)).release_value_but_fixme_should_propagate_errors()); m_value_label->set_text(String::formatted("{:.2f}", static_cast<double>(m_parameter)).release_value_but_fixme_should_propagate_errors());

4
Userland/Libraries/LibGUI/LinkLabel.cpp
View file

@ -118,9 +118,9 @@ void LinkLabel::did_change_text()
void LinkLabel::update_tooltip_if_needed() void LinkLabel::update_tooltip_if_needed()
{ {
if (width() < font().width(text())) { if (width() < font().width(text())) {
set_tooltip_deprecated(text().to_deprecated_string()); set_tooltip(text());
} else { } else {
set_tooltip_deprecated({}); set_tooltip({});
} }
} }