RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 03:27:45 +00:00
Code Issues Activity Actions

LibJS: Convert Intl::CollatorCompareFunction::create() to NonnullGCPtr

Browse source
This commit is contained in:
Linus Groh 2022-12-13 20:49:50 +00:00
parent 83de01043f
commit 46acce5142
3 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibJS/Runtime/Intl/CollatorCompareFunction.cpp
View file

@ -11,9 +11,9 @@
namespace JS::Intl { namespace JS::Intl {
CollatorCompareFunction* CollatorCompareFunction::create(Realm& realm, Collator& collator) NonnullGCPtr<CollatorCompareFunction> CollatorCompareFunction::create(Realm& realm, Collator& collator)
{ {
return realm.heap().allocate<CollatorCompareFunction>(realm, realm, collator); return *realm.heap().allocate<CollatorCompareFunction>(realm, realm, collator);
} }
CollatorCompareFunction::CollatorCompareFunction(Realm& realm, Collator& collator) CollatorCompareFunction::CollatorCompareFunction(Realm& realm, Collator& collator)

2
Userland/Libraries/LibJS/Runtime/Intl/CollatorCompareFunction.h
View file

@ -14,7 +14,7 @@ class CollatorCompareFunction : public NativeFunction {
JS_OBJECT(CollatorCompareFunction, NativeFunction); JS_OBJECT(CollatorCompareFunction, NativeFunction);
public: public:
static CollatorCompareFunction* create(Realm&, Collator&); static NonnullGCPtr<CollatorCompareFunction> create(Realm&, Collator&);
virtual void initialize(Realm&) override; virtual void initialize(Realm&) override;
virtual ~CollatorCompareFunction() override = default; virtual ~CollatorCompareFunction() override = default;

2
Userland/Libraries/LibJS/Runtime/Intl/CollatorPrototype.cpp
View file

@ -44,7 +44,7 @@ JS_DEFINE_NATIVE_FUNCTION(CollatorPrototype::compare_getter)
if (!collator->bound_compare()) { if (!collator->bound_compare()) {
// a. Let F be a new built-in function object as defined in 10.3.3.1. // a. Let F be a new built-in function object as defined in 10.3.3.1.
// b. Set F.[[Collator]] to collator. // b. Set F.[[Collator]] to collator.
auto* function = CollatorCompareFunction::create(realm, *collator); auto function = CollatorCompareFunction::create(realm, *collator);
// c. Set collator.[[BoundCompare]] to F. // c. Set collator.[[BoundCompare]] to F.
collator->set_bound_compare(function); collator->set_bound_compare(function);