RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-06-19 23:32:07 +00:00
Code Issues Activity Actions

LibELF: Remove "always bind now" global flag

Browse source 
This looked like someone's forgotten debug mechanism.
This commit is contained in:
Andreas Kling 2021-02-20 22:35:11 +01:00
parent ba1eea9898
commit 46c3ff2acf
1 changed files with 1 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibELF/DynamicLoader.cpp
View file

@ -49,8 +49,6 @@ static void* mmap_with_name(void* addr, size_t length, int prot, int flags, int
namespace ELF { namespace ELF {
static bool s_always_bind_now = false;
RefPtr<DynamicLoader> DynamicLoader::try_create(int fd, String filename) RefPtr<DynamicLoader> DynamicLoader::try_create(int fd, String filename)
{ {
struct stat stat; struct stat stat;
@ -497,7 +495,7 @@ DynamicLoader::RelocationResult DynamicLoader::do_relocation(size_t total_tls_si
} }
case R_386_JMP_SLOT: { case R_386_JMP_SLOT: {
// FIXME: Or BIND_NOW flag passed in? // FIXME: Or BIND_NOW flag passed in?
if (m_dynamic_object->must_bind_now() || s_always_bind_now) { if (m_dynamic_object->must_bind_now()) {
// Eagerly BIND_NOW the PLT entries, doing all the symbol looking goodness // Eagerly BIND_NOW the PLT entries, doing all the symbol looking goodness
// The patch method returns the address for the LAZY fixup path, but we don't need it here // The patch method returns the address for the LAZY fixup path, but we don't need it here
dbgln_if(DYNAMIC_LOAD_DEBUG, "patching plt reloaction: {:p}", relocation.offset_in_section()); dbgln_if(DYNAMIC_LOAD_DEBUG, "patching plt reloaction: {:p}", relocation.offset_in_section());