RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 04:27:44 +00:00
Code Issues Activity Actions

LibJS: Convert EnvironmentRecord & friends to east-const style

Browse source
This commit is contained in:
Andreas Kling 2021-06-21 23:26:50 +02:00
parent 6c6dbcfc36
commit 46f2c23030
6 changed files with 14 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibJS/Runtime/DeclarativeEnvironmentRecord.cpp
View file

@ -52,12 +52,12 @@ void DeclarativeEnvironmentRecord::visit_edges(Visitor& visitor)
visitor.visit(it.value.value); visitor.visit(it.value.value);
} }
Optional<Variable> DeclarativeEnvironmentRecord::get_from_scope(const FlyString& name) const Optional<Variable> DeclarativeEnvironmentRecord::get_from_scope(FlyString const& name) const
{ {
return m_variables.get(name); return m_variables.get(name);
} }
void DeclarativeEnvironmentRecord::put_to_scope(const FlyString& name, Variable variable) void DeclarativeEnvironmentRecord::put_to_scope(FlyString const& name, Variable variable)
{ {
m_variables.set(name, variable); m_variables.set(name, variable);
} }

8
Userland/Libraries/LibJS/Runtime/DeclarativeEnvironmentRecord.h
View file

@ -37,15 +37,13 @@ public:
virtual ~DeclarativeEnvironmentRecord() override; virtual ~DeclarativeEnvironmentRecord() override;
// ^EnvironmentRecord // ^EnvironmentRecord
virtual Optional<Variable> get_from_scope(const FlyString&) const override; virtual Optional<Variable> get_from_scope(FlyString const&) const override;
virtual void put_to_scope(const FlyString&, Variable) override; virtual void put_to_scope(FlyString const&, Variable) override;
virtual bool delete_from_scope(FlyString const&) override; virtual bool delete_from_scope(FlyString const&) override;
virtual bool has_this_binding() const override; virtual bool has_this_binding() const override;
virtual Value get_this_binding(GlobalObject&) const override; virtual Value get_this_binding(GlobalObject&) const override;
void clear(); HashMap<FlyString, Variable> const& variables() const { return m_variables; }
const HashMap<FlyString, Variable>& variables() const { return m_variables; }
void set_home_object(Value object) { m_home_object = object; } void set_home_object(Value object) { m_home_object = object; }
bool has_super_binding() const; bool has_super_binding() const;

6
Userland/Libraries/LibJS/Runtime/EnvironmentRecord.h
View file

@ -19,14 +19,14 @@ class EnvironmentRecord : public Object {
JS_OBJECT(EnvironmentRecord, Object); JS_OBJECT(EnvironmentRecord, Object);
public: public:
virtual Optional<Variable> get_from_scope(const FlyString&) const = 0; virtual Optional<Variable> get_from_scope(FlyString const&) const = 0;
virtual void put_to_scope(const FlyString&, Variable) = 0; virtual void put_to_scope(FlyString const&, Variable) = 0;
virtual bool delete_from_scope(FlyString const&) = 0; virtual bool delete_from_scope(FlyString const&) = 0;
virtual bool has_this_binding() const = 0; virtual bool has_this_binding() const = 0;
virtual Value get_this_binding(GlobalObject&) const = 0; virtual Value get_this_binding(GlobalObject&) const = 0;
EnvironmentRecord* parent() { return m_parent; } EnvironmentRecord* parent() { return m_parent; }
const EnvironmentRecord* parent() const { return m_parent; } EnvironmentRecord const* parent() const { return m_parent; }
protected: protected:
explicit EnvironmentRecord(EnvironmentRecord* parent); explicit EnvironmentRecord(EnvironmentRecord* parent);

4
Userland/Libraries/LibJS/Runtime/GlobalObject.h
View file

@ -21,8 +21,8 @@ public:
virtual ~GlobalObject() override; virtual ~GlobalObject() override;
virtual Optional<Variable> get_from_scope(const FlyString&) const override; virtual Optional<Variable> get_from_scope(FlyString const&) const override;
virtual void put_to_scope(const FlyString&, Variable) override; virtual void put_to_scope(FlyString const&, Variable) override;
virtual bool delete_from_scope(FlyString const&) override; virtual bool delete_from_scope(FlyString const&) override;
virtual bool has_this_binding() const override; virtual bool has_this_binding() const override;
virtual Value get_this_binding(GlobalObject&) const override; virtual Value get_this_binding(GlobalObject&) const override;

4
Userland/Libraries/LibJS/Runtime/ObjectEnvironmentRecord.cpp
View file

@ -21,7 +21,7 @@ void ObjectEnvironmentRecord::visit_edges(Cell::Visitor& visitor)
visitor.visit(&m_object); visitor.visit(&m_object);
} }
Optional<Variable> ObjectEnvironmentRecord::get_from_scope(const FlyString& name) const Optional<Variable> ObjectEnvironmentRecord::get_from_scope(FlyString const& name) const
{ {
auto value = m_object.get(name); auto value = m_object.get(name);
if (value.is_empty()) if (value.is_empty())
@ -29,7 +29,7 @@ Optional<Variable> ObjectEnvironmentRecord::get_from_scope(const FlyString& name
return Variable { value, DeclarationKind::Var }; return Variable { value, DeclarationKind::Var };
} }
void ObjectEnvironmentRecord::put_to_scope(const FlyString& name, Variable variable) void ObjectEnvironmentRecord::put_to_scope(FlyString const& name, Variable variable)
{ {
m_object.put(name, variable.value); m_object.put(name, variable.value);
} }

4
Userland/Libraries/LibJS/Runtime/ObjectEnvironmentRecord.h
View file

@ -16,8 +16,8 @@ class ObjectEnvironmentRecord : public EnvironmentRecord {
public: public:
ObjectEnvironmentRecord(Object&, EnvironmentRecord* parent_scope); ObjectEnvironmentRecord(Object&, EnvironmentRecord* parent_scope);
virtual Optional<Variable> get_from_scope(const FlyString&) const override; virtual Optional<Variable> get_from_scope(FlyString const&) const override;
virtual void put_to_scope(const FlyString&, Variable) override; virtual void put_to_scope(FlyString const&, Variable) override;
virtual bool delete_from_scope(FlyString const&) override; virtual bool delete_from_scope(FlyString const&) override;
virtual bool has_this_binding() const override; virtual bool has_this_binding() const override;
virtual Value get_this_binding(GlobalObject&) const override; virtual Value get_this_binding(GlobalObject&) const override;