RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 11:57:35 +00:00
Code Issues Activity Actions

LibCore: Change Account::set_password to take a SecretString

Browse source 
This matches the API of Account::authenticate. The only caller to this
API is the passwd utility, which already has the new password stored as
a SecretString.
This commit is contained in:
Timothy Flynn 2021-10-19 09:32:47 -04:00 • committed by Andreas Kling
parent fcff6b7160
commit 4739982c66
3 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibCore/Account.cpp
View file

@ -188,9 +188,9 @@ bool Account::login() const
return true; return true;
} }
void Account::set_password(const char* password) void Account::set_password(SecretString const& password)
{ {
m_password_hash = crypt(password, get_salt().characters()); m_password_hash = crypt(password.characters(), get_salt().characters());
} }
void Account::set_password_enabled(bool enabled) void Account::set_password_enabled(bool enabled)

2
Userland/Libraries/LibCore/Account.h
View file

@ -45,7 +45,7 @@ public:
// Setters only affect in-memory copy of password. // Setters only affect in-memory copy of password.
// You must call sync to apply changes. // You must call sync to apply changes.
void set_password(const char* password); void set_password(SecretString const& password);
void set_password_enabled(bool enabled); void set_password_enabled(bool enabled);
void set_home_directory(const char* home_directory) { m_home_directory = home_directory; } void set_home_directory(const char* home_directory) { m_home_directory = home_directory; }
void set_uid(uid_t uid) { m_uid = uid; } void set_uid(uid_t uid) { m_uid = uid; }

2
Userland/Utilities/passwd.cpp
View file

@ -121,7 +121,7 @@ int main(int argc, char** argv)
return 1; return 1;
} }
target_account.set_password(new_password.value().characters()); target_account.set_password(new_password.value());
} }
if (pledge("stdio wpath rpath cpath fattr", nullptr) < 0) { if (pledge("stdio wpath rpath cpath fattr", nullptr) < 0) {