From 4745a0c20ad4aea463b56e0869f565dd2b74fc3f Mon Sep 17 00:00:00 2001 From: martinfalisse Date: Sat, 15 Oct 2022 13:15:56 +0200 Subject: [PATCH] LibWeb: Implement more of the grid spec This is a small change that implements more of the CSS Grid spec. --- .../LibWeb/Layout/GridFormattingContext.cpp | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/Userland/Libraries/LibWeb/Layout/GridFormattingContext.cpp b/Userland/Libraries/LibWeb/Layout/GridFormattingContext.cpp index 96bc28e8e5..d0a38a6da3 100644 --- a/Userland/Libraries/LibWeb/Layout/GridFormattingContext.cpp +++ b/Userland/Libraries/LibWeb/Layout/GridFormattingContext.cpp @@ -652,6 +652,11 @@ void GridFormattingContext::run(Box const& box, LayoutMode, AvailableSpace const default: VERIFY_NOT_REACHED(); } + + // In all cases, if the growth limit is less than the base size, increase the growth limit to match + // the base size. + if (grid_column.growth_limit != -1 && grid_column.growth_limit < grid_column.base_size) + grid_column.growth_limit = grid_column.base_size; } // Initialize each track’s base size and growth limit. @@ -698,10 +703,12 @@ void GridFormattingContext::run(Box const& box, LayoutMode, AvailableSpace const default: VERIFY_NOT_REACHED(); } - } - // FIXME: In all cases, if the growth limit is less than the base size, increase the growth limit to match - // the base size. + // In all cases, if the growth limit is less than the base size, increase the growth limit to match + // the base size. + if (grid_row.growth_limit != -1 && grid_row.growth_limit < grid_row.base_size) + grid_row.growth_limit = grid_row.base_size; + } // https://www.w3.org/TR/css-grid-2/#algo-content // 12.5. Resolve Intrinsic Track Sizes