RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 07:07:34 +00:00
Code Issues Activity Actions

Applets/Network: Stop marking methods virtual unnecessarily

Browse source 
None of these are overridden, and NetworkWidget is a final class.
This commit is contained in:
Sam Atkins 2022-09-13 12:33:38 +01:00 • committed by Brian Gianforcaro
parent eacf017112
commit 474a38bd3c
1 changed files with 6 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Userland/Applets/Network/main.cpp
View file

@ -1,5 +1,6 @@
/* /*
* Copyright (c) 2020, the SerenityOS developers. * Copyright (c) 2020, the SerenityOS developers.
* Copyright (c) 2022, Sam Atkins <atkinssj@serenityos.org>
* *
* SPDX-License-Identifier: BSD-2-Clause * SPDX-License-Identifier: BSD-2-Clause
*/ */
@ -16,9 +17,6 @@
#include <LibGUI/Window.h> #include <LibGUI/Window.h>
#include <LibGfx/Bitmap.h> #include <LibGfx/Bitmap.h>
#include <LibMain/Main.h> #include <LibMain/Main.h>
#include <serenity.h>
#include <spawn.h>
#include <stdio.h>
class NetworkWidget final : public GUI::ImageWidget { class NetworkWidget final : public GUI::ImageWidget {
C_OBJECT_ABSTRACT(NetworkWidget) C_OBJECT_ABSTRACT(NetworkWidget)
@ -53,7 +51,7 @@ private:
GUI::Process::spawn_or_show_error(window(), "/bin/SystemMonitor"sv, Array { "-t", "network" }); GUI::Process::spawn_or_show_error(window(), "/bin/SystemMonitor"sv, Array { "-t", "network" });
} }
virtual void update_widget() void update_widget()
{ {
auto adapter_info = get_adapter_info(); auto adapter_info = get_adapter_info();
@ -74,7 +72,7 @@ private:
update(); update();
} }
virtual void notify_on_connect() void notify_on_connect()
{ {
if (!m_notifications) if (!m_notifications)
return; return;
@ -85,7 +83,7 @@ private:
notification->show(); notification->show();
} }
virtual void notify_on_disconnect() void notify_on_disconnect()
{ {
if (!m_notifications) if (!m_notifications)
return; return;
@ -96,7 +94,7 @@ private:
notification->show(); notification->show();
} }
virtual void set_connected(bool connected) void set_connected(bool connected)
{ {
if (m_connected != connected) { if (m_connected != connected) {
connected ? notify_on_connect() : notify_on_disconnect(); connected ? notify_on_connect() : notify_on_disconnect();
@ -105,7 +103,7 @@ private:
m_connected = connected; m_connected = connected;
} }
virtual String get_adapter_info() String get_adapter_info()
{ {
StringBuilder adapter_info; StringBuilder adapter_info;