mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 19:17:44 +00:00
LibJS: Pass Interpreter& to Value::to_number() et al.
This patch is unfortunately rather large and might make some things feel bloated, but it is necessary to fix a few flaws in LibJS, primarily blindly coercing values to numbers without exception checks - i.e. interpreter.argument(0).to_i32(); // can fail!!! Some examples where the interpreter would actually crash: var o = { toString: () => { throw Error() } }; +o; o - 1; "foo".charAt(o); "bar".repeat(o); To fix this, we now have the following... to_double(Interpreter&) to_i32() to_i32(Interpreter&) to_size_t() to_size_t(Interpreter&) ...and a whole lot of exception checking. There's intentionally no to_double(), use as_double() directly instead. This way we still can use these convenient utility functions but don't need to check for exceptions if we are sure the value already is a number. Fixes #2267.
This commit is contained in:
parent
1a1394f7a2
commit
476094922b
17 changed files with 491 additions and 187 deletions
|
@ -188,11 +188,13 @@ public:
|
|||
PrimitiveString* to_primitive_string(Interpreter&);
|
||||
Value to_primitive(Interpreter&) const;
|
||||
Object* to_object(Interpreter&) const;
|
||||
bool to_boolean() const;
|
||||
Value to_number() const;
|
||||
Value to_number(Interpreter&) const;
|
||||
double to_double(Interpreter&) const;
|
||||
i32 to_i32() const;
|
||||
double to_double() const;
|
||||
i32 to_i32(Interpreter&) const;
|
||||
size_t to_size_t() const;
|
||||
size_t to_size_t(Interpreter&) const;
|
||||
bool to_boolean() const;
|
||||
|
||||
Value value_or(Value fallback) const
|
||||
{
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue