RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 11:57:34 +00:00
Code Issues Activity Actions

LibJS: Convert create_global_var_binding() to ThrowCompletionOr

Browse source
This commit is contained in:
Linus Groh 2021-12-29 16:00:36 +01:00
parent 8296d3fbd2
commit 4767be1459
4 changed files with 14 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

21
Userland/Libraries/LibJS/Runtime/GlobalEnvironment.cpp
View file

@ -241,35 +241,25 @@ ThrowCompletionOr<bool> GlobalEnvironment::can_declare_global_function(FlyString
}
// 9.1.1.4.17 CreateGlobalVarBinding ( N, D ), https://tc39.es/ecma262/#sec-createglobalvarbinding
void GlobalEnvironment::create_global_var_binding(FlyString const& name, bool can_be_deleted)
ThrowCompletionOr<void> GlobalEnvironment::create_global_var_binding(FlyString const& name, bool can_be_deleted)
{
// 1. Let ObjRec be envRec.[[ObjectRecord]].
// 2. Let globalObject be ObjRec.[[BindingObject]].
auto& global_object = m_object_record->binding_object();
// 3. Let hasProperty be ? HasOwnProperty(globalObject, N).
auto has_property_or_error = global_object.has_own_property(name);
if (has_property_or_error.is_error())
return;
auto has_property = has_property_or_error.release_value();
auto has_property = TRY(global_object.has_own_property(name));
// 4. Let extensible be ? IsExtensible(globalObject).
auto extensible_or_error = global_object.is_extensible();
if (extensible_or_error.is_error())
return;
auto extensible = extensible_or_error.release_value();
auto extensible = TRY(global_object.is_extensible());
// 5. If hasProperty is false and extensible is true, then
if (!has_property && extensible) {
// a. Perform ? ObjRec.CreateMutableBinding(N, D).
auto result = m_object_record->create_mutable_binding(m_object_record->global_object(), name, can_be_deleted);
if (result.is_error())
return;
TRY(m_object_record->create_mutable_binding(m_object_record->global_object(), name, can_be_deleted));
// b. Perform ? ObjRec.InitializeBinding(N, undefined).
result = m_object_record->initialize_binding(m_object_record->global_object(), name, js_undefined());
if (result.is_error())
return;
TRY(m_object_record->initialize_binding(m_object_record->global_object(), name, js_undefined()));
}
// 6. Let varDeclaredNames be envRec.[[VarNames]].
@ -280,6 +270,7 @@ void GlobalEnvironment::create_global_var_binding(FlyString const& name, bool ca
}
// 8. Return NormalCompletion(empty).
return {};
}
// 9.1.1.4.18 CreateGlobalFunctionBinding ( N, V, D ), https://tc39.es/ecma262/#sec-createglobalfunctionbinding