RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 08:07:44 +00:00
Code Issues Activity Actions

LibJS: Make Value::as_cell() return a Cell&

Browse source
This commit is contained in:
Andreas Kling 2021-05-25 18:48:11 +02:00
parent 0de954e86b
commit 47a4b2ba9f
3 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibJS/Heap/Heap.cpp
View file

@ -92,7 +92,7 @@ void Heap::gather_roots(HashTable<Cell*>& roots)
for (auto* list : m_marked_value_lists) { for (auto* list : m_marked_value_lists) {
for (auto& value : list->values()) { for (auto& value : list->values()) {
if (value.is_cell()) if (value.is_cell())
roots.set(value.as_cell()); roots.set(&value.as_cell());
} }
} }

6
Userland/Libraries/LibJS/Runtime/VM.cpp
View file

@ -93,15 +93,15 @@ void VM::gather_roots(HashTable<Cell*>& roots)
roots.set(m_exception); roots.set(m_exception);
if (m_last_value.is_cell()) if (m_last_value.is_cell())
roots.set(m_last_value.as_cell()); roots.set(&m_last_value.as_cell());
for (auto& call_frame : m_call_stack) { for (auto& call_frame : m_call_stack) {
if (call_frame->this_value.is_cell()) if (call_frame->this_value.is_cell())
roots.set(call_frame->this_value.as_cell()); roots.set(&call_frame->this_value.as_cell());
roots.set(call_frame->arguments_object); roots.set(call_frame->arguments_object);
for (auto& argument : call_frame->arguments) { for (auto& argument : call_frame->arguments) {
if (argument.is_cell()) if (argument.is_cell())
roots.set(argument.as_cell()); roots.set(&argument.as_cell());
} }
roots.set(call_frame->scope); roots.set(call_frame->scope);
} }

6
Userland/Libraries/LibJS/Runtime/Value.h
View file

@ -222,10 +222,10 @@ public:
return *m_value.as_symbol; return *m_value.as_symbol;
} }
Cell* as_cell() Cell& as_cell()
{ {
VERIFY(is_cell()); VERIFY(is_cell());
return m_value.as_cell; return *m_value.as_cell;
} }
Accessor& as_accessor() Accessor& as_accessor()
@ -330,7 +330,7 @@ inline Value js_negative_infinity()
inline void Cell::Visitor::visit(Value value) inline void Cell::Visitor::visit(Value value)
{ {
if (value.is_cell()) if (value.is_cell())
visit_impl(*value.as_cell()); visit_impl(value.as_cell());
} }
Value greater_than(GlobalObject&, Value lhs, Value rhs); Value greater_than(GlobalObject&, Value lhs, Value rhs);