RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 14:27:35 +00:00
Code Issues Activity Actions

LibWeb: Include element attributes in innerHTML getter

Browse source
This commit is contained in:
Linus Groh 2020-12-17 13:37:40 +00:00 • committed by Andreas Kling
parent f36feb42bd
commit 4833f0066e
1 changed files with 31 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

33
Libraries/LibWeb/DOM/Element.cpp
View file

@ -271,19 +271,48 @@ void Element::set_inner_html(StringView markup)
String Element::inner_html() const String Element::inner_html() const
{ {
auto escape_string = [](const StringView& string, bool attribute_mode) -> String {
// https://html.spec.whatwg.org/multipage/parsing.html#escapingString
StringBuilder builder;
for (auto& ch : string) {
if (ch == '&')
builder.append("&");
// FIXME: also replace U+00A0 NO-BREAK SPACE with  
else if (ch == '"' && attribute_mode)
builder.append(""");
else if (ch == '<' && !attribute_mode)
builder.append("&lt;");
else if (ch == '>' && !attribute_mode)
builder.append("&gt;");
else
builder.append(ch);
}
return builder.to_string();
};
StringBuilder builder; StringBuilder builder;
Function<void(const Node&)> recurse = [&](auto& node) { Function<void(const Node&)> recurse = [&](auto& node) {
for (auto* child = node.first_child(); child; child = child->next_sibling()) { for (auto* child = node.first_child(); child; child = child->next_sibling()) {
if (child->is_element()) { if (child->is_element()) {
auto& element = downcast<Element>(*child);
builder.append('<'); builder.append('<');
builder.append(downcast<Element>(*child).local_name()); builder.append(element.local_name());
element.for_each_attribute([&](auto& name, auto& value) {
builder.append(' ');
builder.append(name);
builder.append('=');
builder.append('"');
builder.append(escape_string(value, true));
builder.append('"');
});
builder.append('>'); builder.append('>');
recurse(*child); recurse(*child);
// FIXME: This should be skipped for void elements
builder.append("</"); builder.append("</");
builder.append(downcast<Element>(*child).local_name()); builder.append(element.local_name());
builder.append('>'); builder.append('>');
} }
if (child->is_text()) { if (child->is_text()) {