RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 11:18:11 +00:00
Code Issues Activity Actions

JSSpecCompiler: Store arguments in declaration instead of definition

Browse source 
And create a struct encapsulating argument name in the preparation for
argument types and optional arguments.
This commit is contained in:
Dan Klishch 2024-01-15 23:02:35 -05:00 • committed by Andrew Kaster
parent 0806ccaeec
commit 483e195e48
8 changed files with 57 additions and 40 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Meta/Lagom/Tools/CodeGenerators/JSSpecCompiler/Function.h
View file

@ -38,24 +38,28 @@ private:
HashMap<StringView, FunctionDeclarationRef> m_function_index;
};
struct FunctionArgument {
StringView name;
};
class FunctionDeclaration : public RefCounted<FunctionDeclaration> {
public:
FunctionDeclaration(StringView name);
FunctionDeclaration(StringView name, Vector<FunctionArgument>&& arguments);
virtual ~FunctionDeclaration() = default;
TranslationUnitRef m_translation_unit = nullptr;
StringView m_name;
Vector<FunctionArgument> m_arguments;
};
class FunctionDefinition : public FunctionDeclaration {
public:
FunctionDefinition(StringView name, Tree ast, Vector<StringView>&& argument_names);
FunctionDefinition(StringView name, Tree ast, Vector<FunctionArgument>&& arguments);
void reindex_ssa_variables();
Tree m_ast;
Vector<StringView> m_argument_names;
// Populates during reference resolving
// NOTE: The hash map here is ordered since we do not want random hash changes to break our test
@ -67,7 +71,7 @@ public:
RefPtr<ControlFlowGraph> m_cfg;
// Fields populate during SSA building
Vector<SSAVariableDeclarationRef> m_arguments;
Vector<SSAVariableDeclarationRef> m_ssa_arguments;
SSAVariableDeclarationRef m_return_value;
Vector<SSAVariableDeclarationRef> m_local_ssa_variables;
};