RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-30 22:28:12 +00:00
Code Issues Activity Actions

LibDebug: Use StringBuilder in append_to_line_info()

Browse source 
This avoids a lot of temporary allocations and speeds up launching
UE on a large executable by quite a bit.
This commit is contained in:
Andreas Kling 2020-11-15 13:12:07 +01:00
parent adabcf24ec
commit 485d28298a
1 changed files with 7 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Libraries/LibDebug/Dwarf/LineProgram.cpp
View file

@ -25,8 +25,8 @@
*/ */
#include "LineProgram.h" #include "LineProgram.h"
#include <AK/String.h> #include <AK/String.h>
#include <AK/StringBuilder.h>
//#define DWARF_DEBUG //#define DWARF_DEBUG
@ -100,8 +100,12 @@ void LineProgram::append_to_line_info()
return; return;
String directory = m_source_directories[m_source_files[m_file_index].directory_index]; String directory = m_source_directories[m_source_files[m_file_index].directory_index];
String full_path = String::format("%s/%s", directory.characters(), m_source_files[m_file_index].name.characters());
m_lines.append({ m_address, full_path, m_line }); StringBuilder full_path(directory.length() + m_source_files[m_file_index].name.length());
full_path.append(directory);
full_path.append(m_source_files[m_file_index].name);
m_lines.append({ m_address, full_path.to_string(), m_line });
} }
void LineProgram::reset_registers() void LineProgram::reset_registers()