mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 15:07:45 +00:00
Kernel: Make copy_{from,to}_user() return KResult and use TRY()
This makes EFAULT propagation flow much more naturally. :^)
This commit is contained in:
parent
9903f5c6ef
commit
48a0b31c47
57 changed files with 318 additions and 551 deletions
|
@ -316,9 +316,7 @@ KResult KeyboardDevice::ioctl(FileDescription&, unsigned request, Userspace<void
|
|||
switch (request) {
|
||||
case KEYBOARD_IOCTL_GET_NUM_LOCK: {
|
||||
auto output = static_ptr_cast<bool*>(arg);
|
||||
if (!copy_to_user(output, &m_num_lock_on))
|
||||
return EFAULT;
|
||||
return KSuccess;
|
||||
return copy_to_user(output, &m_num_lock_on);
|
||||
}
|
||||
case KEYBOARD_IOCTL_SET_NUM_LOCK: {
|
||||
// In this case we expect the value to be a boolean and not a pointer.
|
||||
|
@ -330,9 +328,7 @@ KResult KeyboardDevice::ioctl(FileDescription&, unsigned request, Userspace<void
|
|||
}
|
||||
case KEYBOARD_IOCTL_GET_CAPS_LOCK: {
|
||||
auto output = static_ptr_cast<bool*>(arg);
|
||||
if (!copy_to_user(output, &m_caps_lock_on))
|
||||
return EFAULT;
|
||||
return KSuccess;
|
||||
return copy_to_user(output, &m_caps_lock_on);
|
||||
}
|
||||
case KEYBOARD_IOCTL_SET_CAPS_LOCK: {
|
||||
auto caps_lock_value = static_cast<u8>(arg.ptr());
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue