RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-21 15:15:07 +00:00
Code Issues Activity Actions

Shell: Silence TCSETPGRP errors when not interactive

Browse source
This commit is contained in:
AnotherTest 2020-12-06 20:52:08 +03:30 • committed by Andreas Kling
parent 57728ef29f
commit 48a1f7e55c
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Shell/Shell.cpp
View file

@ -817,13 +817,13 @@ RefPtr<Job> Shell::run_command(const AST::Command& command)
pid_t pgid = is_first ? child : (command.pipeline ? command.pipeline->pgid : child); pid_t pgid = is_first ? child : (command.pipeline ? command.pipeline->pgid : child);
if ((!m_is_subshell && command.should_wait) || command.pipeline) { if ((!m_is_subshell && command.should_wait) || command.pipeline) {
if (setpgid(child, pgid) < 0) if (setpgid(child, pgid) < 0 && m_is_interactive)
perror("setpgid"); perror("setpgid");
if (!m_is_subshell) { if (!m_is_subshell) {
if (tcsetpgrp(STDOUT_FILENO, pgid) != 0) if (tcsetpgrp(STDOUT_FILENO, pgid) != 0 && m_is_interactive)
perror("tcsetpgrp(OUT)"); perror("tcsetpgrp(OUT)");
if (tcsetpgrp(STDIN_FILENO, pgid) != 0) if (tcsetpgrp(STDIN_FILENO, pgid) != 0 && m_is_interactive)
perror("tcsetpgrp(IN)"); perror("tcsetpgrp(IN)");
} }
} }