RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 07:57:46 +00:00
Code Issues Activity Actions

AK: Use TypedTransfer to move vector's inline buffer

Browse source 
This avoids an explicit loop-move when the type is trivial.
This commit is contained in:
Ali Mohammad Pur 2022-11-03 10:33:52 +03:30 • committed by Ali Mohammad Pur
parent 6970bf03a9
commit 48a4c9c1ad
2 changed files with 17 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

17
AK/TypedTransfer.h
View file

@ -31,7 +31,7 @@ public:
} }
} }
static size_t copy(T* destination, const T* source, size_t count) static size_t copy(T* destination, T const* source, size_t count)
{ {
if (count == 0) if (count == 0)
return 0; return 0;
@ -54,7 +54,7 @@ public:
return count; return count;
} }
static bool compare(const T* a, const T* b, size_t count) static bool compare(T const* a, T const* b, size_t count)
{ {
if (count == 0) if (count == 0)
return true; return true;
@ -69,6 +69,19 @@ public:
return true; return true;
} }
static void delete_(T* ptr, size_t count)
{
if (count == 0)
return;
if constexpr (Traits<T>::is_trivial()) {
return;
}
for (size_t i = 0; i < count; ++i)
ptr[i].~T();
}
}; };
} }

6
AK/Vector.h
View file

@ -73,10 +73,8 @@ public:
{ {
if constexpr (inline_capacity > 0) { if constexpr (inline_capacity > 0) {
if (!m_outline_buffer) { if (!m_outline_buffer) {
for (size_t i = 0; i < m_size; ++i) { TypedTransfer<T>::move(inline_buffer(), other.inline_buffer(), m_size);
new (&inline_buffer()[i]) StorageType(move(other.inline_buffer()[i])); TypedTransfer<T>::delete_(other.inline_buffer(), m_size);
other.inline_buffer()[i].~StorageType();
}
} }
} }
other.m_outline_buffer = nullptr; other.m_outline_buffer = nullptr;