RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 01:08:11 +00:00
Code Issues Activity Actions

LibJS: Move Bytecode::Instruction::execute() to the Op.h header

Browse source 
..and make sure it always gets inlined in the interpreter loop.
This commit is contained in:
Andreas Kling 2021-06-09 09:19:34 +02:00
parent b61f198d22
commit 48a8022cf6
3 changed files with 20 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Userland/Libraries/LibJS/Bytecode/Interpreter.cpp
View file

@ -8,6 +8,7 @@
#include <LibJS/Bytecode/BasicBlock.h> #include <LibJS/Bytecode/BasicBlock.h>
#include <LibJS/Bytecode/Instruction.h> #include <LibJS/Bytecode/Instruction.h>
#include <LibJS/Bytecode/Interpreter.h> #include <LibJS/Bytecode/Interpreter.h>
#include <LibJS/Bytecode/Op.h>
#include <LibJS/Runtime/GlobalObject.h> #include <LibJS/Runtime/GlobalObject.h>
namespace JS::Bytecode { namespace JS::Bytecode {

15
Userland/Libraries/LibJS/Bytecode/Op.cpp
View file

@ -16,21 +16,6 @@
namespace JS::Bytecode { namespace JS::Bytecode {
void Instruction::execute(Bytecode::Interpreter& interpreter) const
{
#define __BYTECODE_OP(op) \
case Instruction::Type::op: \
return static_cast<Bytecode::Op::op const&>(*this).execute(interpreter);
switch (type()) {
ENUMERATE_BYTECODE_OPS(__BYTECODE_OP)
default:
VERIFY_NOT_REACHED();
}
#undef __BYTECODE_OP
}
String Instruction::to_string() const String Instruction::to_string() const
{ {
#define __BYTECODE_OP(op) \ #define __BYTECODE_OP(op) \

19
Userland/Libraries/LibJS/Bytecode/Op.h
View file

@ -374,3 +374,22 @@ public:
}; };
} }
namespace JS::Bytecode {
ALWAYS_INLINE void Instruction::execute(Bytecode::Interpreter& interpreter) const
{
#define __BYTECODE_OP(op) \
case Instruction::Type::op: \
return static_cast<Bytecode::Op::op const&>(*this).execute(interpreter);
switch (type()) {
ENUMERATE_BYTECODE_OPS(__BYTECODE_OP)
default:
VERIFY_NOT_REACHED();
}
#undef __BYTECODE_OP
}
}