RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 19:38:12 +00:00
Code Issues Activity Actions

LibWeb: Make NodeList GC-allocated

Browse source
This commit is contained in:
Andreas Kling 2022-09-01 16:30:26 +02:00
parent 8f4ea4e308
commit 48e0066371
16 changed files with 128 additions and 57 deletions
Download patch file Download diff file Expand all files Collapse all files

22
Userland/Libraries/LibWeb/DOM/StaticNodeList.cpp
View file

@ -5,17 +5,29 @@
*/
#include <LibWeb/DOM/StaticNodeList.h>
#include <LibWeb/HTML/Window.h>
namespace Web::DOM {
NonnullRefPtr<NodeList> StaticNodeList::create(Vector<JS::Handle<Node>> static_nodes)
JS::NonnullGCPtr<NodeList> StaticNodeList::create(HTML::Window& window, Vector<JS::Handle<Node>> static_nodes)
{
return adopt_ref(*new StaticNodeList(move(static_nodes)));
return *window.heap().allocate<StaticNodeList>(window.realm(), window, move(static_nodes));
}
StaticNodeList::StaticNodeList(Vector<JS::Handle<Node>> static_nodes)
: m_static_nodes(move(static_nodes))
StaticNodeList::StaticNodeList(HTML::Window& window, Vector<JS::Handle<Node>> static_nodes)
: NodeList(window)
{
for (auto& node : static_nodes)
m_static_nodes.append(*node);
}
StaticNodeList::~StaticNodeList() = default;
void StaticNodeList::visit_edges(Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
for (auto& node : m_static_nodes)
visitor.visit(node);
}
// https://dom.spec.whatwg.org/#dom-nodelist-length
@ -30,7 +42,7 @@ Node const* StaticNodeList::item(u32 index) const
// The item(index) method must return the indexth node in the collection. If there is no indexth node in the collection, then the method must return null.
if (index >= m_static_nodes.size())
return nullptr;
return m_static_nodes[index].ptr();
return &m_static_nodes[index];
}
// https://dom.spec.whatwg.org/#ref-for-dfn-supported-property-indices