RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 02:07:35 +00:00
Code Issues Activity Actions

LibGUI: Remove Window background color

Browse source 
The `m_background_color` field was not used anywhere. Both `Terminal`
and the `ColorPicker` widget invoked `set_background_color()` to no
avail.
This commit is contained in:
Jelle Raaijmakers 2022-01-31 00:17:32 +01:00 • committed by Andreas Kling
parent 687276fc38
commit 48eecaad64
3 changed files with 0 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Userland/Applications/Terminal/main.cpp
View file

@ -283,7 +283,6 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
auto window = TRY(GUI::Window::try_create()); auto window = TRY(GUI::Window::try_create());
window->set_title("Terminal"); window->set_title("Terminal");
window->set_background_color(Color::Black);
window->set_double_buffering_enabled(false); window->set_double_buffering_enabled(false);
auto terminal = TRY(window->try_set_main_widget<VT::TerminalWidget>(ptm_fd, true)); auto terminal = TRY(window->try_set_main_widget<VT::TerminalWidget>(ptm_fd, true));

1
Userland/Libraries/LibGUI/ColorPicker.cpp
View file

@ -137,7 +137,6 @@ public:
auto window = Window::construct(); auto window = Window::construct();
window->set_main_widget(this); window->set_main_widget(this);
window->set_has_alpha_channel(true); window->set_has_alpha_channel(true);
window->set_background_color(Color::Transparent);
window->set_fullscreen(true); window->set_fullscreen(true);
window->set_frameless(true); window->set_frameless(true);
window->show(); window->show();

5
Userland/Libraries/LibGUI/Window.h
View file

@ -15,7 +15,6 @@
#include <LibGUI/FocusSource.h> #include <LibGUI/FocusSource.h>
#include <LibGUI/Forward.h> #include <LibGUI/Forward.h>
#include <LibGUI/WindowType.h> #include <LibGUI/WindowType.h>
#include <LibGfx/Color.h>
#include <LibGfx/Forward.h> #include <LibGfx/Forward.h>
#include <LibGfx/Rect.h> #include <LibGfx/Rect.h>
#include <LibGfx/StandardCursor.h> #include <LibGfx/StandardCursor.h>
@ -76,9 +75,6 @@ public:
String title() const; String title() const;
void set_title(String); void set_title(String);
Color background_color() const { return m_background_color; }
void set_background_color(Color color) { m_background_color = color; }
enum class CloseRequestDecision { enum class CloseRequestDecision {
StayOpen, StayOpen,
Close, Close,
@ -283,7 +279,6 @@ private:
Vector<Gfx::IntRect, 32> m_pending_paint_event_rects; Vector<Gfx::IntRect, 32> m_pending_paint_event_rects;
Gfx::IntSize m_size_increment; Gfx::IntSize m_size_increment;
Gfx::IntSize m_base_size; Gfx::IntSize m_base_size;
Color m_background_color { Color::WarmGray };
WindowType m_window_type { WindowType::Normal }; WindowType m_window_type { WindowType::Normal };
AK::Variant<Gfx::StandardCursor, NonnullRefPtr<Gfx::Bitmap>> m_cursor { Gfx::StandardCursor::None }; AK::Variant<Gfx::StandardCursor, NonnullRefPtr<Gfx::Bitmap>> m_cursor { Gfx::StandardCursor::None };
AK::Variant<Gfx::StandardCursor, NonnullRefPtr<Gfx::Bitmap>> m_effective_cursor { Gfx::StandardCursor::None }; AK::Variant<Gfx::StandardCursor, NonnullRefPtr<Gfx::Bitmap>> m_effective_cursor { Gfx::StandardCursor::None };