From 4901f69345907eb381b0b0cdaa41147a362c1db9 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Sat, 3 Sep 2022 15:24:36 +0200 Subject: [PATCH] LibWeb: Don't capture raw ptr in Document::completely_finish_loading() It's not safe to capture a raw pointer in a HTML task, as the garbage collector doesn't have visibility into the task captures. --- Userland/Libraries/LibWeb/DOM/Document.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Userland/Libraries/LibWeb/DOM/Document.cpp b/Userland/Libraries/LibWeb/DOM/Document.cpp index 432ad4d445..21ffb80ef7 100644 --- a/Userland/Libraries/LibWeb/DOM/Document.cpp +++ b/Userland/Libraries/LibWeb/DOM/Document.cpp @@ -1399,7 +1399,7 @@ void Document::completely_finish_loading() // FIXME: 2. Set document's completely loaded time to the current time. // 3. Let container be document's browsing context's container. - auto* container = browsing_context()->container(); + auto container = JS::make_handle(browsing_context()->container()); // If container is an iframe element, then queue an element task on the DOM manipulation task source given container to run the iframe load event steps given container. if (container && is(*container)) {