RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 04:37:34 +00:00
Code Issues Activity Actions

Kernel/Audio: Simplify initialization sequence for drivers

Browse source 
Instead of enumerating all available controllers and then ask each to
find its audio channels, we change the initialization sequence to match
what happens in the Networking subsystem and Graphics subsystem - we
essentially probe for a matching driver on a PCI device, create a device
instance, and immediately initialize it.

This in fact allows us to immediately find any hardware initialization
issues and report it, and then dropping the created instance, as usually
being done in other initialization paths in the Kernel.

This also opens the opportunity to propagate errors when failed to
initialize an AudioChannel instance, and it will be addressed in a
future commit.
This commit is contained in:
Liav A 2023-04-11 12:45:31 +03:00 • committed by Linus Groh
parent 0050358cd3
commit 4921561687
7 changed files with 77 additions and 72 deletions
Download patch file Download diff file Expand all files Collapse all files

33
Kernel/Devices/Audio/IntelHDA/Controller.cpp
View file

@ -16,13 +16,16 @@
namespace Kernel::Audio::IntelHDA {
UNMAP_AFTER_INIT ErrorOr<NonnullLockRefPtr<Controller>> Controller::create(PCI::DeviceIdentifier const& pci_device_identifier)
UNMAP_AFTER_INIT ErrorOr<bool> Controller::probe(PCI::DeviceIdentifier const& device_identifier)
{
VERIFY(device_identifier.class_code().value() == to_underlying(PCI::ClassID::Multimedia));
return device_identifier.subclass_code().value() == to_underlying(PCI::Multimedia::SubclassID::HDACompatibleController);
}
UNMAP_AFTER_INIT ErrorOr<NonnullRefPtr<AudioController>> Controller::create(PCI::DeviceIdentifier const& pci_device_identifier)
{
auto controller_io_window = TRY(IOWindow::create_for_pci_device_bar(pci_device_identifier, PCI::HeaderType0BaseRegister::BAR0));
auto intel_hda = TRY(adopt_nonnull_lock_ref_or_enomem(new (nothrow) Controller(pci_device_identifier, move(controller_io_window))));
TRY(intel_hda->initialize());
return intel_hda;
return TRY(adopt_nonnull_ref_or_enomem(new (nothrow) Controller(pci_device_identifier, move(controller_io_window))));
}
UNMAP_AFTER_INIT Controller::Controller(PCI::DeviceIdentifier const& pci_device_identifier, NonnullOwnPtr<IOWindow> controller_io_window)
@ -31,7 +34,7 @@ UNMAP_AFTER_INIT Controller::Controller(PCI::DeviceIdentifier const& pci_device_
{
}
UNMAP_AFTER_INIT ErrorOr<void> Controller::initialize()
UNMAP_AFTER_INIT ErrorOr<void> Controller::initialize(Badge<AudioManagement>)
{
// Enable DMA
PCI::enable_bus_mastering(device_identifier());
@ -83,6 +86,13 @@ UNMAP_AFTER_INIT ErrorOr<void> Controller::initialize()
}
}
auto result = configure_output_route();
if (result.is_error()) {
dmesgln_pci(*this, "Failed to set up an output audio channel: {}", result.error());
return result.release_error();
}
m_audio_channel = AudioChannel::must_create(*this, fixed_audio_channel_index);
return {};
}
@ -294,17 +304,6 @@ ErrorOr<size_t> Controller::write(size_t channel_index, UserOrKernelBuffer const
return m_output_path->output_stream().write(data, length);
}
UNMAP_AFTER_INIT void Controller::detect_hardware_audio_channels(Badge<AudioManagement>)
{
auto result = configure_output_route();
if (result.is_error()) {
dmesgln_pci(*this, "Failed to set up an output audio channel: {}", result.error());
return;
}
m_audio_channel = AudioChannel::must_create(*this, fixed_audio_channel_index);
}
ErrorOr<void> Controller::set_pcm_output_sample_rate(size_t channel_index, u32 samples_per_second_rate)
{
if (channel_index != fixed_audio_channel_index || !m_output_path)