RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 06:07:34 +00:00
Code Issues Activity Actions

Spreadsheet: Move to a non-owning model for Stream in Writer::XSV

Browse source
This commit is contained in:
Lucas CHOLLET 2023-01-14 12:11:29 -05:00 • committed by Ali Mohammad Pur
parent fc413711ee
commit 4952cdfe2b
5 changed files with 75 additions and 59 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Applications/Spreadsheet/Writers/Test/TestXSVWriter.cpp
View file

@ -7,7 +7,6 @@
#include <LibTest/TestCase.h>
#include "../CSV.h"
#include "../XSV.h"
#include <LibCore/MemoryStream.h>
TEST_CASE(can_write)
@ -19,8 +18,7 @@ TEST_CASE(can_write)
};
Core::Stream::AllocatingMemoryStream stream;
auto csv = Writer::CSV(Core::Stream::Handle<Core::Stream::Stream>(stream), data);
MUST(csv.generate());
MUST(Writer::CSV::generate(stream, data));
auto expected_output = R"~(1,2,3
4,5,6
@ -40,8 +38,7 @@ TEST_CASE(can_write_with_header)
};
Core::Stream::AllocatingMemoryStream stream;
auto csv = Writer::CSV(Core::Stream::Handle<Core::Stream::Stream>(stream), data, { "A"sv, "B\""sv, "C"sv });
MUST(csv.generate());
MUST(Writer::CSV::generate(stream, data, { "A"sv, "B\""sv, "C"sv }));
auto expected_output = R"~(A,"B""",C
1,2,3
@ -61,8 +58,7 @@ TEST_CASE(can_write_with_different_behaviors)
};
Core::Stream::AllocatingMemoryStream stream;
auto csv = Writer::CSV(Core::Stream::Handle<Core::Stream::Stream>(stream), data, { "A"sv, "B\""sv, "C"sv }, Writer::WriterBehavior::QuoteOnlyInFieldStart | Writer::WriterBehavior::WriteHeaders);
MUST(csv.generate());
MUST(Writer::CSV::generate(stream, data, { "A"sv, "B\""sv, "C"sv }, Writer::WriterBehavior::QuoteOnlyInFieldStart | Writer::WriterBehavior::WriteHeaders));
auto expected_output = R"~(A,B",C
Well,Hello",Friends