RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-23 19:47:42 +00:00
Code Issues Activity Actions

LibGUI: Show human readable size in filemanager

Browse source 
The size is visible only in TableView mode of the filemanager.
This commit is contained in:
Federico Guerinoni 2021-03-25 22:01:29 +01:00 • committed by Andreas Kling
parent 8fe7983cc5
commit 49a062f81d
2 changed files with 4 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Applications/FileManager/DirectoryView.cpp
View file

@ -413,10 +413,8 @@ void DirectoryView::update_statusbar()
size_t selected_byte_count = 0; size_t selected_byte_count = 0;
current_view().selection().for_each_index([&](auto& index) { current_view().selection().for_each_index([&](auto& index) {
auto& model = *current_view().model(); const auto& node = this->node(index);
auto size_index = model.index(index.row(), GUI::FileSystemModel::Column::Size, model.parent_index(index)); selected_byte_count += node.size;
auto file_size = size_index.data().to_i32();
selected_byte_count += file_size;
}); });
StringBuilder builder; StringBuilder builder;

3
Userland/Libraries/LibGUI/FileSystemModel.cpp
View file

@ -25,6 +25,7 @@
*/ */
#include <AK/LexicalPath.h> #include <AK/LexicalPath.h>
#include <AK/NumberFormat.h>
#include <AK/QuickSort.h> #include <AK/QuickSort.h>
#include <AK/StringBuilder.h> #include <AK/StringBuilder.h>
#include <LibCore/DirIterator.h> #include <LibCore/DirIterator.h>
@ -439,7 +440,7 @@ Variant FileSystemModel::data(const ModelIndex& index, ModelRole role) const
case Column::Name: case Column::Name:
return node.name; return node.name;
case Column::Size: case Column::Size:
return (int)node.size; return human_readable_size(node.size);
case Column::Owner: case Column::Owner:
return name_for_uid(node.uid); return name_for_uid(node.uid);
case Column::Group: case Column::Group: