RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 20:22:45 +00:00
Code Issues Activity Actions

Kernel/FileSystem: Fix check of read offset for the RAMFSInode code

Browse source 
The check of ensuring we are not trying to read beyond the end of the
inode data buffer is already there, it's just that we need to disallow
further reading if the read offset equals to the inode data size.
This commit is contained in:
Liav A 2023-02-18 16:48:45 +02:00 • committed by Andreas Kling
parent 9790b81959
commit 4a14138230
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Kernel/FileSystem/RAMFS/Inode.cpp
View file

@ -127,7 +127,7 @@ ErrorOr<size_t> RAMFSInode::read_bytes_from_content_space(size_t offset, size_t
{
VERIFY(m_inode_lock.is_locked());
VERIFY(m_metadata.size >= 0);
if (static_cast<size_t>(m_metadata.size) < offset)
if (offset >= static_cast<size_t>(m_metadata.size))
return 0;
auto mapping_region = TRY(MM.allocate_kernel_region(DataBlock::block_size, "RAMFSInode Mapping Region"sv, Memory::Region::Access::Read, AllocationStrategy::Reserve));
return const_cast<RAMFSInode&>(*this).do_io_on_content_space(*mapping_region, offset, io_size, buffer, false);