RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 17:57:35 +00:00
Code Issues Activity Actions

Kernel: Accept NNRP<Socket> instead of RP<Socket> in release_for_accept

Browse source 
This value is always non-null, so let's make it explicit.
This commit is contained in:
Idan Horowitz 2022-04-09 22:25:39 +03:00 • committed by Andreas Kling
parent 472a3df03b
commit 4a270c93ed
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Kernel/Net/TCPSocket.cpp
View file

@ -150,16 +150,16 @@ ErrorOr<NonnullRefPtr<TCPSocket>> TCPSocket::try_create_client(IPv4Address const
void TCPSocket::release_to_originator() void TCPSocket::release_to_originator()
{ {
VERIFY(!!m_originator); VERIFY(!!m_originator);
m_originator.strong_ref()->release_for_accept(this); m_originator.strong_ref()->release_for_accept(*this);
m_originator.clear(); m_originator.clear();
} }
void TCPSocket::release_for_accept(RefPtr<TCPSocket> socket) void TCPSocket::release_for_accept(NonnullRefPtr<TCPSocket> socket)
{ {
VERIFY(m_pending_release_for_accept.contains(socket->tuple())); VERIFY(m_pending_release_for_accept.contains(socket->tuple()));
m_pending_release_for_accept.remove(socket->tuple()); m_pending_release_for_accept.remove(socket->tuple());
// FIXME: Should we observe this error somehow? // FIXME: Should we observe this error somehow?
[[maybe_unused]] auto rc = queue_connection_from(*socket); [[maybe_unused]] auto rc = queue_connection_from(move(socket));
} }
TCPSocket::TCPSocket(int protocol, NonnullOwnPtr<DoubleBuffer> receive_buffer, NonnullOwnPtr<KBuffer> scratch_buffer) TCPSocket::TCPSocket(int protocol, NonnullOwnPtr<DoubleBuffer> receive_buffer, NonnullOwnPtr<KBuffer> scratch_buffer)

2
Kernel/Net/TCPSocket.h
View file

@ -154,7 +154,7 @@ public:
void set_originator(TCPSocket& originator) { m_originator = originator; } void set_originator(TCPSocket& originator) { m_originator = originator; }
bool has_originator() { return !!m_originator; } bool has_originator() { return !!m_originator; }
void release_to_originator(); void release_to_originator();
void release_for_accept(RefPtr<TCPSocket>); void release_for_accept(NonnullRefPtr<TCPSocket>);
void retransmit_packets(); void retransmit_packets();