RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 00:17:46 +00:00
Code Issues Activity Actions

Kernel: Rename File::{before_removing => will_be_destroyed}

Browse source 
This will allow File and it's descendants to use RefCounted instead of
having a custom implementation of unref. (Since RefCounted calls
will_be_destroyed automatically)

This commit also removes an erroneous call to `before_removing` in
AHCIPort, this is a duplicate call, as the only reference to the device
is immediately dropped following the call, which in turns calls
`before_removing` via File::unref.
This commit is contained in:
Idan Horowitz 2021-12-29 01:00:29 +02:00 • committed by Andreas Kling
parent d7ec5d042f
commit 4a3a947df3
6 changed files with 5 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Kernel/FileSystem/File.h
View file

@ -75,7 +75,7 @@ class File
, public Weakable<File> {
public:
virtual bool unref() const;
virtual void before_removing() { }
virtual void will_be_destroyed() { }
virtual ~File();
virtual ErrorOr<NonnullRefPtr<OpenFileDescription>> open(int options);