mirror of
https://github.com/RGBCube/serenity
synced 2025-07-27 04:07:45 +00:00
LibWeb: Shift button paintable clip rectangle by scroll offset
Rectangles should be recorded using absolute coordinates, including the scroll offset.
This commit is contained in:
parent
d43dbe2842
commit
4a41a65ec5
4 changed files with 54 additions and 4 deletions
|
@ -60,7 +60,9 @@ void ButtonPaintable::paint(PaintContext& context, PaintPhase phase) const
|
|||
// Paint button text clipped to button rect
|
||||
auto& painter = context.recording_painter();
|
||||
painter.save();
|
||||
painter.add_clip_rect(button_rect.to_type<int>());
|
||||
auto clip_rect = absolute_rect();
|
||||
clip_rect.translate_by(enclosing_scroll_frame_offset().value_or({}));
|
||||
painter.add_clip_rect(context.enclosing_device_rect(clip_rect).to_type<int>());
|
||||
painter.draw_text(
|
||||
text_rect.to_type<int>(),
|
||||
static_cast<HTML::HTMLInputElement const&>(dom_node).value(),
|
||||
|
|
|
@ -199,6 +199,8 @@ public:
|
|||
void set_corner_clip_radii(BorderRadiiData const& corner_radii) { m_corner_clip_radii = corner_radii; }
|
||||
|
||||
Optional<int> scroll_frame_id() const { return m_scroll_frame_id; }
|
||||
Optional<CSSPixelPoint> enclosing_scroll_frame_offset() const { return m_enclosing_scroll_frame_offset; }
|
||||
Optional<CSSPixelRect> clip_rect() const { return m_clip_rect; }
|
||||
|
||||
protected:
|
||||
explicit PaintableBox(Layout::Box const&);
|
||||
|
@ -211,9 +213,6 @@ protected:
|
|||
virtual CSSPixelRect compute_absolute_rect() const;
|
||||
virtual CSSPixelRect compute_absolute_paint_rect() const;
|
||||
|
||||
Optional<CSSPixelPoint> enclosing_scroll_frame_offset() const { return m_enclosing_scroll_frame_offset; }
|
||||
Optional<CSSPixelRect> clip_rect() const { return m_clip_rect; }
|
||||
|
||||
private:
|
||||
[[nodiscard]] virtual bool is_paintable_box() const final { return true; }
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue