RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 22:28:11 +00:00
Code Issues Activity Actions

LibDebug: Put DWARF debug logging spam behind DEBUG_SPAM

Browse source 
With this logging enabled, it takes way too long to load debug info.
This commit is contained in:
Andreas Kling 2020-07-21 18:18:54 +02:00
parent 0e172f8ed7
commit 4a572df465
1 changed files with 8 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Libraries/LibDebug/DebugInfo.cpp
View file

@ -30,6 +30,8 @@
#include <LibDebug/Dwarf/DwarfInfo.h>
#include <LibDebug/Dwarf/Expression.h>
//#define DEBUG_SPAM
DebugInfo::DebugInfo(NonnullRefPtr<const ELF::Loader> elf)
: m_elf(elf)
, m_dwarf_info(Dwarf::DwarfInfo::create(m_elf))
@ -55,11 +57,15 @@ void DebugInfo::parse_scopes_impl(const Dwarf::DIE& die)
return;
if (child.get_attribute(Dwarf::Attribute::Inline).has_value()) {
#ifdef DEBUG_SPAM
dbg() << "DWARF inlined functions are not supported";
#endif
return;
}
if (child.get_attribute(Dwarf::Attribute::Ranges).has_value()) {
#ifdef DEBUG_SPAM
dbg() << "DWARF ranges are not supported";
#endif
return;
}
auto name = child.get_attribute(Dwarf::Attribute::Name);
@ -70,7 +76,9 @@ void DebugInfo::parse_scopes_impl(const Dwarf::DIE& die)
scope.name = name.value().data.as_string;
if (!child.get_attribute(Dwarf::Attribute::LowPc).has_value()) {
#ifdef DEBUG_SPAM
dbg() << "DWARF: Couldn't find attribtue LowPc for scope";
#endif
return;
}
scope.address_low = child.get_attribute(Dwarf::Attribute::LowPc).value().data.as_u32;