RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 02:17:34 +00:00
Code Issues Activity Actions

LibX86: Remove some allocations from Instruction::to_string

Browse source 
Instruction::to_string used to copy a string literal into a String,
and then the String into a StringBuilder. Copy it to the StringBuilder
directly.

No measurable performance benefit, but it's also less code.
This commit is contained in:
Nico Weber 2020-08-16 13:29:02 -04:00 • committed by Andreas Kling
parent 5558b2cf9f
commit 4a57cbc98f
1 changed files with 10 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

35
Libraries/LibX86/Instruction.cpp
View file

@ -1208,32 +1208,17 @@ static String relative_address(u32 origin, bool x32, i32 imm)
String Instruction::to_string(u32 origin, const SymbolProvider* symbol_provider, bool x32) const String Instruction::to_string(u32 origin, const SymbolProvider* symbol_provider, bool x32) const
{ {
String segment_prefix;
String asize_prefix;
String osize_prefix;
String rep_prefix;
String lock_prefix;
if (m_segment_prefix.has_value()) {
segment_prefix = String::format("%s: ", register_name(m_segment_prefix.value()));
}
if (has_address_size_override_prefix()) {
asize_prefix = m_a32 ? "a32 " : "a16 ";
}
if (has_operand_size_override_prefix()) {
osize_prefix = m_o32 ? "o32 " : "o16 ";
}
if (has_lock_prefix()) {
lock_prefix = "lock ";
}
if (has_rep_prefix()) {
rep_prefix = m_rep_prefix == Prefix::REPNZ ? "repnz " : "repz ";
}
StringBuilder builder; StringBuilder builder;
builder.append(segment_prefix); if (m_segment_prefix.has_value())
builder.append(asize_prefix); builder.appendf("%s: ", register_name(m_segment_prefix.value()));
builder.append(osize_prefix); if (has_address_size_override_prefix())
builder.append(lock_prefix); builder.append(m_a32 ? "a32 " : "a16 ");
builder.append(rep_prefix); if (has_operand_size_override_prefix())
builder.append(m_o32 ? "o32 " : "o16 ");
if (has_lock_prefix())
builder.append("lock ");
if (has_rep_prefix())
builder.append(m_rep_prefix == Prefix::REPNZ ? "repnz " : "repz ");
builder.append(to_string_internal(origin, symbol_provider, x32)); builder.append(to_string_internal(origin, symbol_provider, x32));
return builder.to_string(); return builder.to_string();
} }