RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 12:12:45 +00:00
Code Issues Activity Actions

LibWeb: Declare defaulted style value comparision operators inline

Browse source 
Some versions of clang, such as Apple clang-1400.0.29.202 error out on
the previous out of line operators. Explicitly defaulting comparison
operators out of line is allowed per P2085R0, but was checked in clang
before version 15 in C++20 mode.
This commit is contained in:
Andrew Kaster 2023-03-26 12:08:36 -06:00 • committed by Linus Groh
parent 840afbb55f
commit 4a70fa052f
4 changed files with 2 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/CSS/StyleValues/ContentStyleValue.cpp
View file

@ -19,6 +19,4 @@ ErrorOr<String> ContentStyleValue::to_string() const
return m_properties.content->to_string();
}
bool ContentStyleValue::Properties::operator==(ContentStyleValue::Properties const&) const = default;
}

2
Userland/Libraries/LibWeb/CSS/StyleValues/ContentStyleValue.h
View file

@ -39,7 +39,7 @@ private:
struct Properties {
ValueComparingNonnullRefPtr<StyleValueList> content;
ValueComparingRefPtr<StyleValueList> alt_text;
bool operator==(Properties const&) const;
bool operator==(Properties const&) const = default;
} m_properties;
};

2
Userland/Libraries/LibWeb/CSS/StyleValues/GridAreaShorthandStyleValue.cpp
View file

@ -40,6 +40,4 @@ ErrorOr<String> GridAreaShorthandStyleValue::to_string() const
return builder.to_string();
}
bool GridAreaShorthandStyleValue::Properties::operator==(GridAreaShorthandStyleValue::Properties const&) const = default;
}

2
Userland/Libraries/LibWeb/CSS/StyleValues/GridAreaShorthandStyleValue.h
View file

@ -44,7 +44,7 @@ private:
ValueComparingNonnullRefPtr<GridTrackPlacementStyleValue const> column_start;
ValueComparingNonnullRefPtr<GridTrackPlacementStyleValue const> row_end;
ValueComparingNonnullRefPtr<GridTrackPlacementStyleValue const> column_end;
bool operator==(Properties const&) const;
bool operator==(Properties const&) const = default;
} m_properties;
};